op-e2e: Don't override the sequencer window in tests where it shouldn't be needed #12502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t be needed. Use a longer window in the one test it may affect - 16 does get hit unexpectedly in CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12502 +/- ##
===========================================
- Coverage 64.60% 64.42% -0.19%
===========================================
Files 52 52
Lines 4371 4371
===========================================
- Hits 2824 2816 -8
- Misses 1372 1381 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
refcell
approved these changes
Oct 17, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…'t be needed. (ethereum-optimism#12502) Use a longer window in the one test it may affect - 16 does get hit unexpectedly in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a longer window in the one test it may affect - 16 does get hit unexpectedly in CI.
We get flakes when the sequencer window is hit and causes an unexpected reorg.